app-layer: remove ALPROTO_TEST and tests#12051
Merged
victorjulien merged 1 commit intoOISF:masterfrom Nov 1, 2024
Merged
Conversation
These tests purpose seems to have been lost. Registering a alproto with a parser function that always fails, and just testing that AppLayerParserParse returned -1... We would get the same result without registering a parser function, or using ALPROTO_FAILED as argument to AppLayerParserParse The comment says "Test the deallocation of app layer parser memory on occurrence of error in the parsing process." but I do not see how this is tested.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12051 +/- ##
==========================================
- Coverage 83.42% 83.40% -0.03%
==========================================
Files 910 910
Lines 257642 257555 -87
==========================================
- Hits 214949 214817 -132
- Misses 42693 42738 +45
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Oct 29, 2024
|
Information: QA ran without warnings. Pipeline 23199 |
Merged
Member
|
Merged in #12074, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
No ticket, just some meaning-lost code removal
Describe changes:
Following #11910 (comment)